Initial MPcules Summary RESTer#758
Open
espottesmith wants to merge 10 commits intomaterialsproject:mainfrom
Open
Initial MPcules Summary RESTer#758espottesmith wants to merge 10 commits intomaterialsproject:mainfrom
espottesmith wants to merge 10 commits intomaterialsproject:mainfrom
Conversation
Beginning MPcules summary rester, modeled off of materials summary rester
Continuing work on minimal rester
Finished very rough draft mpcules summary rester; incorporated into MPRester
Tests still pass, even with new addition. Now just need to write tests for new rester
Some small frustrations with the mpcules summary rester, but ready to PR
Linting and so on
Update version of emmet-core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a RESTer for the MPcules summary endpoint. This should be the minimum required to create the upcoming Molecules Explorer Web app.
Known issues:
Future work: